Quantcast
Channel: blog4umbraco Source Code Rss Feed
Viewing all articles
Browse latest Browse all 20

Patch Uploaded: #9135

$
0
0

pcpdx has uploaded a patch.

Description:
/Blog4Umbraco/AjaxCommentForm.ascx does not work when Javascript is disabled.

The problem is the post is looking for "author" when the field is "name". This subesquently causes the valid comment check on line 34 of Base.cs to fail as the name property is null.

I propose the ajaxCommentForm be changed to better utilize the .net framework and controls as this current version - while is functional with this patch, leaves a little desire for the UX. For example - if the JS-disabled user enters an invalid message, there is no feedback for why their comment has failed. Furthermore, all of their input is gone.
If the user does have a successful comment - they are not presented any feedback message of success or similar. In past experience, if a user doesn't get feedback they will hit [f5] or refresh several times and then give up. -Little do they know that their comment has actually been posted and by hitting refresh so many times..it's been posted 3/4/5/19 times!
I am updating this code in our local as we need to be able to support these changes. I will submit them when i am done should you choose to use them - i strongly urge an update to the ux in any case.

Thanks for all the hard work you have done on this great package!
Hope i can help


Viewing all articles
Browse latest Browse all 20

Latest Images

Trending Articles





Latest Images